KYLIN-1160 code review
Project: http://git-wip-us.apache.org/repos/asf/incubator-kylin/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-kylin/commit/97c50c5b Tree: http://git-wip-us.apache.org/repos/asf/incubator-kylin/tree/97c50c5b Diff: http://git-wip-us.apache.org/repos/asf/incubator-kylin/diff/97c50c5b Branch: refs/heads/2.0-rc Commit: 97c50c5b087e320975f24860e81e4ccd12f4150a Parents: 44b5a76 Author: Li, Yang <yang...@ebay.com> Authored: Fri Nov 27 13:11:39 2015 +0800 Committer: Li, Yang <yang...@ebay.com> Committed: Fri Nov 27 13:11:39 2015 +0800 ---------------------------------------------------------------------- .../main/java/org/apache/kylin/common/util/Log4jConfigurer.java | 4 ++-- .../main/java/org/apache/kylin/jdbc/util/Log4jConfigurer.java | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/97c50c5b/core-common/src/main/java/org/apache/kylin/common/util/Log4jConfigurer.java ---------------------------------------------------------------------- diff --git a/core-common/src/main/java/org/apache/kylin/common/util/Log4jConfigurer.java b/core-common/src/main/java/org/apache/kylin/common/util/Log4jConfigurer.java index c329ced..6f887b7 100644 --- a/core-common/src/main/java/org/apache/kylin/common/util/Log4jConfigurer.java +++ b/core-common/src/main/java/org/apache/kylin/common/util/Log4jConfigurer.java @@ -17,15 +17,15 @@ public class Log4jConfigurer { public static void initLogger() { if (!INITIALIZED && !isConfigured()) { org.apache.log4j.BasicConfigurator.configure(new ConsoleAppender(new PatternLayout(DEFAULT_PATTERN_LAYOUT))); - INITIALIZED = true; } + INITIALIZED = true; } private static boolean isConfigured() { if (LogManager.getRootLogger().getAllAppenders().hasMoreElements()) { return true; } else { - Enumeration loggers = LogManager.getCurrentLoggers(); + Enumeration<?> loggers = LogManager.getCurrentLoggers(); while (loggers.hasMoreElements()) { Logger logger = (Logger) loggers.nextElement(); if (logger.getAllAppenders().hasMoreElements()) http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/97c50c5b/jdbc/src/main/java/org/apache/kylin/jdbc/util/Log4jConfigurer.java ---------------------------------------------------------------------- diff --git a/jdbc/src/main/java/org/apache/kylin/jdbc/util/Log4jConfigurer.java b/jdbc/src/main/java/org/apache/kylin/jdbc/util/Log4jConfigurer.java index 715d190..8bf35e2 100644 --- a/jdbc/src/main/java/org/apache/kylin/jdbc/util/Log4jConfigurer.java +++ b/jdbc/src/main/java/org/apache/kylin/jdbc/util/Log4jConfigurer.java @@ -17,15 +17,15 @@ public class Log4jConfigurer { public static void initLogger() { if (!INITIALIZED && !isConfigured()) { org.apache.log4j.BasicConfigurator.configure(new ConsoleAppender(new PatternLayout(DEFAULT_PATTERN_LAYOUT))); - INITIALIZED = true; } + INITIALIZED = true; } private static boolean isConfigured() { if (LogManager.getRootLogger().getAllAppenders().hasMoreElements()) { return true; } else { - Enumeration loggers = LogManager.getCurrentLoggers(); + Enumeration<?> loggers = LogManager.getCurrentLoggers(); while (loggers.hasMoreElements()) { Logger logger = (Logger) loggers.nextElement(); if (logger.getAllAppenders().hasMoreElements())
