yaooqinn commented on a change in pull request #822:
URL: https://github.com/apache/incubator-kyuubi/pull/822#discussion_r671943706
##########
File path:
kyuubi-common/src/main/scala/org/apache/kyuubi/session/SessionManager.scala
##########
@@ -66,11 +66,11 @@ abstract class SessionManager(name: String) extends
CompositeService(name) {
def closeSession(sessionHandle: SessionHandle): Unit = {
_latestLogoutTime = System.currentTimeMillis()
val session = handleToSession.remove(sessionHandle)
- if (session == null) {
- throw KyuubiSQLException(s"Invalid $sessionHandle")
+ if (session != null) {
+ session.close()
+ } else {
+ warn(s"$sessionHandle is closed, current opening sessions
$getOpenSessionCount")
Review comment:
this belongs to if-branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
