ulysses-you commented on a change in pull request #814:
URL: https://github.com/apache/incubator-kyuubi/pull/814#discussion_r671967246
##########
File path:
externals/kyuubi-spark-monitor/src/main/scala/org/apache/kyuubi/engine/spark/monitor/KyuubiStatementMonitor.scala
##########
@@ -36,17 +42,34 @@ object KyuubiStatementMonitor extends Logging{
* b. this queue's current size
*/
// TODO: Capacity should make configurable
- private val kyuubiStatementQueue = new
ArrayBlockingQueue[KyuubiStatementInfo](10)
+ private val kyuubiStatementQueue = new
ArrayBlockingQueue[KyuubiStatementInfo](maxCapacity)
+
+ /**
+ * This map store the relationship between jobId and jobInfo.
+ * When the job has finished, all we can get is jobId from the object-jobEnd.
+ * So we need to maintain a mapping relationship to store endTime and
jobResult
+ * when this job has finished.
+ *
+ * Key is jobId, value is KyuubiJobInfo.
+ *
+ * Notice:
+ * 1. There have two kinds of threshold to trigger when to remove and
dump items from this map:
+ * a. time
+ * b. this map's current size
+ */
+ // TODO: Capacity should make configurable
Review comment:
It's better to create a new issue to track this `TODO`, and put that
issue link here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
