[GitHub] [incubator-kyuubi] timothy65535 commented on pull request #826: [KYUUBI #825] Introduce jcommander framework to kyuubi project

[GitBox]

timothy65535 commented on pull request #826:
URL: https://github.com/apache/incubator-kyuubi/pull/826#issuecomment-884606002


   Hi @yaooqinn @pan3793, review again when you are free , thanks.
   
   ### cmd examples
   1. input `--help`
   ```
   Usage: kyuubi-ctl <server|engine|config> [actions] [options] 
   
     engine  Commands on operating engine
     server  Commands on operating server
     config  Commands on operating config
   ```
   
   2. input `server --help`
   ```
   Usage: kyuubi-ctl server [actions] [options]
   create
     -zk, --zk-quorum The connection string for the zookeeper ensemble, using 
zk quorum manually.
     -n, --namespace  The namespace, using kyuubi-defaults/conf if absent.
     -s, --host       Hostname or IP address of a service.
     -p, --port       Listening port of a service.
     -h, --help       
   get
     -zk, --zk-quorum The connection string for the zookeeper ensemble, using 
zk quorum manually.
     -n, --namespace  The namespace, using kyuubi-defaults/conf if absent.
     -s, --host       Hostname or IP address of a service.
     -p, --port       Listening port of a service.
     -h, --help       
   delete
     -zk, --zk-quorum The connection string for the zookeeper ensemble, using 
zk quorum manually.
     -n, --namespace  The namespace, using kyuubi-defaults/conf if absent.
     -s, --host       Hostname or IP address of a service.
     -p, --port       Listening port of a service.
     -h, --help       
   list
     -zk, --zk-quorum The connection string for the zookeeper ensemble, using 
zk quorum manually.
     -n, --namespace  The namespace, using kyuubi-defaults/conf if absent.
     -s, --host       Hostname or IP address of a service.
     -p, --port       Listening port of a service.
     -h, --help       
   ```
   
   3. input `server get --help`
   ```
   get
     -zk, --zk-quorum The connection string for the zookeeper ensemble, using 
                        zk quorum manually.
     -n, --namespace  The namespace, using kyuubi-defaults/conf if absent.
     -s, --host       Hostname or IP address of a service.
     -p, --port       Listening port of a service.
     -h, --help 
   ```
   
   ### Easy to add new more service / command
   1. Add new command which extends `Command`
   2. Add the new command to service command group
   3. If add new service type, need to update `Kyuubi`
   4. ok
   
   
![image](https://user-images.githubusercontent.com/86483005/126579899-83b2ef6f-dc22-43d4-baa4-fc7313bc01ce.png)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org