yaooqinn commented on a change in pull request #857:
URL: https://github.com/apache/incubator-kyuubi/pull/857#discussion_r677082599



##########
File path: docs/deployment/settings.md
##########
@@ -147,6 +147,7 @@ 
kyuubi\.engine<br>\.deregister\.exception<br>\.messages|<div style='width: 65pt;
 kyuubi\.engine<br>\.deregister\.exception<br>\.ttl|<div style='width: 
65pt;word-wrap: break-word;white-space: normal'>PT30M</div>|<div style='width: 
170pt;word-wrap: break-word;white-space: normal'>Time to live(TTL) for 
exceptions pattern specified in kyuubi.engine.deregister.exception.classes and 
kyuubi.engine.deregister.exception.messages to deregister engines. Once the 
total error count hits the kyuubi.engine.deregister.job.max.failures within the 
TTL, an engine will deregister itself and wait for self-terminated. Otherwise, 
we suppose that the engine has recovered from temporary failures.</div>|<div 
style='width: 30pt'>duration</div>|<div style='width: 20pt'>1.2.0</div>
 kyuubi\.engine<br>\.deregister\.job\.max<br>\.failures|<div style='width: 
65pt;word-wrap: break-word;white-space: normal'>4</div>|<div style='width: 
170pt;word-wrap: break-word;white-space: normal'>Number of failures of job 
before deregistering the engine.</div>|<div style='width: 30pt'>int</div>|<div 
style='width: 20pt'>1.2.0</div>
 kyuubi\.engine<br>\.initialize\.sql|<div style='width: 65pt;word-wrap: 
break-word;white-space: normal'>SHOW DATABASES</div>|<div style='width: 
170pt;word-wrap: break-word;white-space: normal'>SemiColon-separated list of 
SQL statements to be initialized in the newly created engine before 
queries.</div>|<div style='width: 30pt'>string</div>|<div style='width: 
20pt'>1.2.0</div>
+kyuubi\.engine\.session<br>\.initialize\.sql|<div style='width: 
65pt;word-wrap: break-word;white-space: normal'>SHOW DATABASES</div>|<div 
style='width: 170pt;word-wrap: break-word;white-space: 
normal'>SemiColon-separated list of SQL statements to be initialized in the 
newly created engine session before queries.</div>|<div style='width: 
30pt'>string</div>|<div style='width: 20pt'>1.3.0</div>

Review comment:
       SemiColon-separated seems not quite friendly to jdbc url




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to