pan3793 commented on a change in pull request #857:
URL: https://github.com/apache/incubator-kyuubi/pull/857#discussion_r677919760
##########
File path:
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/session/SparkSQLSessionManager.scala
##########
@@ -69,6 +75,18 @@ class SparkSQLSessionManager private (name: String, spark:
SparkSession)
setSession(handle, sessionImpl)
info(s"$user's session with $handle is opened, current opening sessions"
+
s" $getOpenSessionCount")
+
+ if (singleSparkSessionInitialized.compareAndSet(false, true)
Review comment:
Addressed 1 and 2.
Have some thoughts on 3, one difference between single session mode and
isolate session mode is that the former uses the engine startup session but the
latter does not. Is it necessary also to execute
`ENGINE_SESSION_INITIALIZE_SQL` following engine startup in isolate session
mode?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
