zwangsheng commented on a change in pull request #1003:
URL: https://github.com/apache/incubator-kyuubi/pull/1003#discussion_r699013424
##########
File path:
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
##########
@@ -379,6 +381,19 @@ object KyuubiConf {
.transform(_.toLowerCase(Locale.ROOT))
.createWithDefault(SaslQOP.AUTH.toString)
+ val FRONTEND_REST_BIND_HOST: OptionalConfigEntry[String] =
buildConf("frontend.rest.bind.host")
+ .doc("Hostname or IP of the machine on which to run the REST frontend
service.")
+ .version("1.0.0")
Review comment:
this version may need to follow the version of Kyuubi
##########
File path:
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
##########
@@ -132,6 +132,8 @@ case class KyuubiConf(loadSysDefault: Boolean = true)
extends Logging {
private val serverOnlyConfEntries: Set[ConfigEntry[_]] = Set(
FRONTEND_BIND_HOST,
Review comment:
Maybe you can refer to LEGACY_ENGINE_SHARE_LEVEL?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
