yaooqinn commented on a change in pull request #1010:
URL: https://github.com/apache/incubator-kyuubi/pull/1010#discussion_r700063345
##########
File path:
kyuubi-server/src/test/scala/org/apache/kyuubi/engine/EngineRefSuite.scala
##########
@@ -66,28 +66,32 @@ class EngineRefSuite extends KyuubiFunSuite {
test(s"${USER} shared level engine name") {
val id = SessionHandle(TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V10)
conf.set(KyuubiConf.ENGINE_SHARE_LEVEL, USER.toString)
- conf.unset(KyuubiConf.ENGINE_SHARE_LEVEL_SUB_DOMAIN)
+ conf.unset(KyuubiConf.ENGINE_SHARE_LEVEL_SUBDOMAIN)
val appName = EngineRef(conf, user, id)
assert(appName.engineSpace === ZKPaths.makePath(s"kyuubi_$USER", user))
assert(appName.defaultEngineName ===
s"kyuubi_${USER}_${user}_${id.identifier}")
- conf.set(KyuubiConf.ENGINE_SHARE_LEVEL_SUB_DOMAIN.key, "abc")
- val appName2 = EngineRef(conf, user, id)
- assert(appName2.engineSpace ===
- ZKPaths.makePath(s"kyuubi_$USER", user, "abc"))
- assert(appName2.defaultEngineName ===
s"kyuubi_${USER}_${user}_abc_${id.identifier}")
+ Seq(KyuubiConf.ENGINE_SHARE_LEVEL_SUBDOMAIN,
Review comment:
keep a test with the legacy conf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
