yaooqinn commented on a change in pull request #1015:
URL: https://github.com/apache/incubator-kyuubi/pull/1015#discussion_r700768688
##########
File path:
kyuubi-common/src/test/scala/org/apache/kyuubi/util/KyuubiHadoopUtilsSuite.scala
##########
@@ -35,4 +37,12 @@ class KyuubiHadoopUtilsSuite extends KyuubiFunSuite {
assert(hadoopConf.get(xyz) === "abc")
assert(hadoopConf.get(test) === "t")
}
+
+ test("encode/decode Writable object") {
+ val writable = new Text("Hello, World!")
+ val decoded = new Text()
+
+ KyuubiHadoopUtils.decodeWritable(decoded,
KyuubiHadoopUtils.encodeWritable(writable))
Review comment:
why doesn't `decodeWritable` named decodeString and return `Text`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
