cfmcgrady commented on a change in pull request #1016:
URL: https://github.com/apache/incubator-kyuubi/pull/1016#discussion_r700998984
##########
File path:
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
##########
@@ -235,61 +235,118 @@ object KyuubiConf {
// Frontend Service Configuration
//
/////////////////////////////////////////////////////////////////////////////////////////////////
+ @deprecated(s"using ${FRONTEND_THRIFT_BIND_HOST.key} instead", "1.4.0")
val FRONTEND_BIND_HOST: OptionalConfigEntry[String] =
buildConf("frontend.bind.host")
- .doc("Hostname or IP of the machine on which to run the frontend service.")
+ .doc("(deprecated) Hostname or IP of the machine on which to run the
thrift frontend service.")
.version("1.0.0")
.stringConf
.createOptional
+ val FRONTEND_THRIFT_BIND_HOST: ConfigEntry[Option[String]] =
+ buildConf("frontend.thrift.bind.host")
+ .doc("Hostname or IP of the machine on which to run the thrift frontend
service.")
+ .version("1.4.0")
+ .fallbackConf(FRONTEND_BIND_HOST)
+
+ @deprecated(s"using ${FRONTEND_THRIFT_BIND_PORT.key} instead", "1.4.0")
val FRONTEND_BIND_PORT: ConfigEntry[Int] = buildConf("frontend.bind.port")
- .doc("Port of the machine on which to run the frontend service.")
+ .doc("(deprecated) Port of the machine on which to run the thrift frontend
service.")
.version("1.0.0")
.intConf
.checkValue(p => p == 0 || (p > 1024 && p < 65535), "Invalid Port number")
.createWithDefault(10009)
+ val FRONTEND_THRIFT_BIND_PORT: ConfigEntry[Int] =
buildConf("frontend.thrift.bind.port")
+ .doc("Port of the machine on which to run the thrift frontend service.")
+ .version("1.4.0")
+ .fallbackConf(FRONTEND_BIND_PORT)
+
+ @deprecated(s"using ${FRONTEND_THRIFT_MIN_WORKER_THREADS.key} instead",
"1.4.0")
val FRONTEND_MIN_WORKER_THREADS: ConfigEntry[Int] =
buildConf("frontend.min.worker.threads")
- .doc("Minimum number of threads in the of frontend worker thread pool for
the frontend" +
- " service")
+ .doc("Minimum number of threads in the of frontend worker thread pool for
the thrift " +
+ "frontend service")
.version("1.0.0")
.intConf
.createWithDefault(9)
+ val FRONTEND_THRIFT_MIN_WORKER_THREADS: ConfigEntry[Int] =
+ buildConf("frontend.thrift.min.worker.threads")
+ .doc("Minimum number of threads in the of frontend worker thread pool for
the thrift " +
+ "frontend service")
+ .version("1.4.0")
+ .fallbackConf(FRONTEND_MIN_WORKER_THREADS)
+
+ @deprecated(s"using ${FRONTEND_THRIFT_MAX_WORKER_THREADS.key} instead",
"1.4.0")
val FRONTEND_MAX_WORKER_THREADS: ConfigEntry[Int] =
buildConf("frontend.max.worker.threads")
- .doc("Maximum number of threads in the of frontend worker thread pool for
the frontend" +
- " service")
+ .doc("Maximum number of threads in the of frontend worker thread pool for
the thrift " +
+ "frontend service")
.version("1.0.0")
.intConf
.createWithDefault(999)
+ val FRONTEND_THRIFT_MAX_WORKER_THREADS: ConfigEntry[Int] =
+ buildConf("frontend.thrift.max.worker.threads")
+ .doc("Maximum number of threads in the of frontend worker thread pool for
the thrift " +
+ "frontend service")
+ .version("1.4.0")
+ .fallbackConf(FRONTEND_MAX_WORKER_THREADS)
+
+ @deprecated(s"using ${FRONTEND_THRIFT_WORKER_KEEPALIVE_TIME.key} instead",
"1.4.0")
val FRONTEND_WORKER_KEEPALIVE_TIME: ConfigEntry[Long] =
buildConf("frontend.worker.keepalive.time")
.doc("Keep-alive time (in milliseconds) for an idle worker thread")
Review comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
