zhouyifan279 commented on a change in pull request #1015: URL: https://github.com/apache/incubator-kyuubi/pull/1015#discussion_r701635269
########## File path: kyuubi-server/src/main/scala/org/apache/kyuubi/credentials/HadoopDelegationProvider.scala ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kyuubi.credentials + +import org.apache.hadoop.conf.Configuration +import org.apache.hadoop.security.Credentials + +import org.apache.kyuubi.Logging +import org.apache.kyuubi.config.KyuubiConf + +trait HadoopDelegationTokenProvider extends Logging { + + /** + * Name of the service to provide delegation tokens. This name should be unique. Kyuubi will + * internally use this name to differentiate delegation token providers. + */ + def serviceName: String + + /** + * Returns true if delegation tokens are required for this service. By default, it is based on + * whether Hadoop security is enabled. + */ + def delegationTokensRequired(hadoopConf: Configuration, kyuubiConf: KyuubiConf): Boolean Review comment: `kyuubiConf` is needed because some providers (if we need to implement in the future), eg kafka, can read configs(server address, or client config file path ) from KyuubiConf; `hadoopConf`can be created using `KyuubiHadoopUtils#newHadoopConf`in each providers. But maybe it is better to keep this logic outside providers to make it a little simpler to write the provider. Besides, it will be easier if we want to change `hadoopConf`'s loading logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
