cfmcgrady commented on a change in pull request #1041:
URL: https://github.com/apache/incubator-kyuubi/pull/1041#discussion_r703007333
##########
File path: dev/kyuubi-extension-spark-3-1/pom.xml
##########
@@ -104,33 +104,21 @@
<dependency>
<groupId>javax.xml.bind</groupId>
<artifactId>jaxb-api</artifactId>
- </dependency>
-
- <dependency>
- <groupId>org.antlr</groupId>
- <artifactId>antlr4-runtime</artifactId>
Review comment:
Just make sure we don't miss anything here, Spark-3.1.2 depends
`antlr4-runtime:4.8-1`, but kyuubi generates source code with
`antlr-maven-plugin:4.7`. Is there any compatibility issue?
https://github.com/apache/spark/blob/de351e30a90dd988b133b3d00fa6218bfcaba8b8/pom.xml#L192
```xml
<antlr4.version>4.8-1</antlr4.version>
```
https://github.com/apache/incubator-kyuubi/blob/4cd83790ae651ee0da92365458b08224d68a6419/pom.xml#L90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
