yaooqinn commented on a change in pull request #1033:
URL: https://github.com/apache/incubator-kyuubi/pull/1033#discussion_r703130113
##########
File path:
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala
##########
@@ -53,23 +53,27 @@ class KyuubiSessionImpl(
case (key, value) => sessionConf.set(key, value)
}
- private val engine: EngineRef = EngineRef(sessionConf, user, handle)
+ private val engine: EngineRef = new EngineRef(sessionConf, user)
private val sessionEvent = KyuubiSessionEvent(this)
EventLoggingService.onEvent(sessionEvent)
private var transport: TTransport = _
private var client: KyuubiSyncThriftClient = _
+ private var _handle: SessionHandle = _
Review comment:
```scala
private final val _handle: SessionHandle = SessionHandle(protocol)
override def handle: SessionHandle = _handle
```
This looks flaky and tricky, compared with `AbstractSession`, can you refine
this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
