zhouyifan279 commented on a change in pull request #1029:
URL: https://github.com/apache/incubator-kyuubi/pull/1029#discussion_r703147446



##########
File path: 
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
##########
@@ -249,6 +249,22 @@ object KyuubiConf {
       .checkValue(t => t > 0, "must be positive integer")
       .createWithDefault(Duration.ofMinutes(1).toMillis)
 
+  val CREDENTIALS_HADOOP_FS_ENABLED: ConfigEntry[Boolean] =
+    buildConf("credentials.hadoopfs.enabled")
+      .doc("Whether to renew HadoopFS DelegationToken")
+      .version("1.4.0")
+      .booleanConf
+      .createWithDefault(true)
+
+  val CREDENTIALS_HADOOP_FS_URLS: ConfigEntry[Seq[String]] =
+    buildConf("credentials.hadoopfs.urls")

Review comment:
       In reference to the 
[discussion](https://github.com/apache/spark/pull/16432#issuecomment-270320823) 
about the serviceName of `HadoopFSCredentialProvider` in Spark, using 
`hadoopfs` to stand for Hadoop Compatible file systems seems to be more 
appropriate.
   
   Maybe we, should rename `credentials.hadoopfs.urls` to 
`credentials.hadoopfs.uris` as they are parsed to java.net.URI objects.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to