ulysses-you commented on a change in pull request #1037:
URL: https://github.com/apache/incubator-kyuubi/pull/1037#discussion_r703322827
##########
File path:
dev/kyuubi-extension-spark-3-1/src/test/resources/sql-classification-default.json
##########
@@ -1,34 +1,60 @@
{
"AlterDatabasePropertiesCommand": "ddl",
- "AlterTableRenameCommand": "ddl",
- "AlterTableRenamePartitionCommand": "ddl",
"AlterTableAddColumnsCommand": "ddl",
- "AlterTableChangeColumnCommand": "ddl",
"AlterTableAddPartitionCommand": "ddl",
+ "AlterTableChangeColumnCommand": "ddl",
"AlterTableDropPartitionCommand": "ddl",
- "AlterTableSetPropertiesCommand": "ddl",
- "AlterTableSetLocationCommand": "ddl",
- "AlterTableSerDePropertiesCommand": "ddl",
- "AlterTableUnsetPropertiesCommand": "ddl",
+ "AlterTableRecoverPartitionsCommand": "ddl",
+ "AlterTableRenameCommand": "ddl",
"AlterTableRenameCommand": "ddl",
+ "AlterTableRenamePartitionCommand": "ddl",
+ "AlterTableSerDePropertiesCommand": "ddl",
+ "AlterTableSetLocationCommand": "ddl",
"AlterTableSetPropertiesCommand": "ddl",
+ "AlterTableSetPropertiesCommand": "ddl",
+ "AlterTableUnsetPropertiesCommand": "ddl",
"AlterTableUnsetPropertiesCommand": "ddl",
"AlterViewAsCommand": "ddl",
+ "CreateDataSourceTableAsSelectCommand": "ddl",
+ "CreateDataSourceTableCommand": "ddl",
"CreateDatabaseCommand": "ddl",
"CreateFunctionCommand": "ddl",
- "CreateDataSourceTableCommand": "ddl",
- "CreateDataSourceTableAsSelectCommand": "ddl",
"CreateTableLikeCommand": "ddl",
"CreateViewCommand": "ddl",
"DropDatabaseCommand": "ddl",
"DropFunctionCommand": "ddl",
- "NoopDropTable": "ddl",
"DropTableCommand": "ddl",
- "TruncateTableCommand": "ddl",
- "AlterTableRecoverPartitionsCommand": "ddl",
+ "NoopDropTable": "ddl",
"SetCatalogAndNamespace": "ddl",
+ "TruncateTableCommand": "ddl",
+ "InsertIntoDataSourceDirCommand": "dml",
"InsertIntoHadoopFsRelationCommand": "dml",
+ "InsertIntoHiveDirCommand": "dml",
Review comment:
insertintodir
##########
File path:
dev/kyuubi-extension-spark-3-1/src/main/resources/sql-classification-default.json
##########
@@ -1,34 +1,60 @@
{
"AlterDatabasePropertiesCommand": "ddl",
- "AlterTableRenameCommand": "ddl",
- "AlterTableRenamePartitionCommand": "ddl",
"AlterTableAddColumnsCommand": "ddl",
- "AlterTableChangeColumnCommand": "ddl",
"AlterTableAddPartitionCommand": "ddl",
+ "AlterTableChangeColumnCommand": "ddl",
"AlterTableDropPartitionCommand": "ddl",
- "AlterTableSetPropertiesCommand": "ddl",
- "AlterTableSetLocationCommand": "ddl",
- "AlterTableSerDePropertiesCommand": "ddl",
- "AlterTableUnsetPropertiesCommand": "ddl",
+ "AlterTableRecoverPartitionsCommand": "ddl",
+ "AlterTableRenameCommand": "ddl",
"AlterTableRenameCommand": "ddl",
+ "AlterTableRenamePartitionCommand": "ddl",
+ "AlterTableSerDePropertiesCommand": "ddl",
+ "AlterTableSetLocationCommand": "ddl",
"AlterTableSetPropertiesCommand": "ddl",
+ "AlterTableSetPropertiesCommand": "ddl",
+ "AlterTableUnsetPropertiesCommand": "ddl",
"AlterTableUnsetPropertiesCommand": "ddl",
"AlterViewAsCommand": "ddl",
+ "CreateDataSourceTableAsSelectCommand": "ddl",
+ "CreateDataSourceTableCommand": "ddl",
"CreateDatabaseCommand": "ddl",
"CreateFunctionCommand": "ddl",
- "CreateDataSourceTableCommand": "ddl",
- "CreateDataSourceTableAsSelectCommand": "ddl",
"CreateTableLikeCommand": "ddl",
"CreateViewCommand": "ddl",
"DropDatabaseCommand": "ddl",
"DropFunctionCommand": "ddl",
- "NoopDropTable": "ddl",
"DropTableCommand": "ddl",
- "TruncateTableCommand": "ddl",
- "AlterTableRecoverPartitionsCommand": "ddl",
+ "NoopDropTable": "ddl",
"SetCatalogAndNamespace": "ddl",
+ "TruncateTableCommand": "ddl",
+ "InsertIntoDataSourceDirCommand": "dml",
"InsertIntoHadoopFsRelationCommand": "dml",
+ "InsertIntoHiveDirCommand": "dml",
"LoadDataCommand": "dml",
- "InsertIntoDataSourceDirCommand": "dml",
- "InsertIntoHiveDirCommand": "dml"
+ "AddFileCommand": "other",
+ "AddJarCommand": "other",
+ "AnalyzeTable": "other",
+ "CacheTableCommand": "other",
+ "ClearCacheCommand$": "other",
+ "DescribeColumnCommand": "other",
+ "DescribeDatabaseCommand": "other",
+ "DescribeFunctionCommand": "other",
+ "DescribeQueryCommand": "other",
+ "DescribeTableCommand": "other",
+ "ListFilesCommand": "other",
+ "ListJarsCommand": "other",
Review comment:
ListArchivesCommand
##########
File path:
dev/kyuubi-extension-spark-3-1/src/main/resources/sql-classification-default.json
##########
@@ -1,34 +1,60 @@
{
"AlterDatabasePropertiesCommand": "ddl",
- "AlterTableRenameCommand": "ddl",
- "AlterTableRenamePartitionCommand": "ddl",
"AlterTableAddColumnsCommand": "ddl",
- "AlterTableChangeColumnCommand": "ddl",
"AlterTableAddPartitionCommand": "ddl",
+ "AlterTableChangeColumnCommand": "ddl",
"AlterTableDropPartitionCommand": "ddl",
- "AlterTableSetPropertiesCommand": "ddl",
- "AlterTableSetLocationCommand": "ddl",
- "AlterTableSerDePropertiesCommand": "ddl",
- "AlterTableUnsetPropertiesCommand": "ddl",
+ "AlterTableRecoverPartitionsCommand": "ddl",
Review comment:
RepairTableCommand
##########
File path:
dev/kyuubi-extension-spark-3-1/src/main/resources/sql-classification-default.json
##########
@@ -1,34 +1,60 @@
{
"AlterDatabasePropertiesCommand": "ddl",
- "AlterTableRenameCommand": "ddl",
- "AlterTableRenamePartitionCommand": "ddl",
"AlterTableAddColumnsCommand": "ddl",
- "AlterTableChangeColumnCommand": "ddl",
"AlterTableAddPartitionCommand": "ddl",
+ "AlterTableChangeColumnCommand": "ddl",
"AlterTableDropPartitionCommand": "ddl",
- "AlterTableSetPropertiesCommand": "ddl",
- "AlterTableSetLocationCommand": "ddl",
- "AlterTableSerDePropertiesCommand": "ddl",
- "AlterTableUnsetPropertiesCommand": "ddl",
+ "AlterTableRecoverPartitionsCommand": "ddl",
+ "AlterTableRenameCommand": "ddl",
"AlterTableRenameCommand": "ddl",
+ "AlterTableRenamePartitionCommand": "ddl",
+ "AlterTableSerDePropertiesCommand": "ddl",
+ "AlterTableSetLocationCommand": "ddl",
"AlterTableSetPropertiesCommand": "ddl",
+ "AlterTableSetPropertiesCommand": "ddl",
+ "AlterTableUnsetPropertiesCommand": "ddl",
"AlterTableUnsetPropertiesCommand": "ddl",
"AlterViewAsCommand": "ddl",
+ "CreateDataSourceTableAsSelectCommand": "ddl",
+ "CreateDataSourceTableCommand": "ddl",
"CreateDatabaseCommand": "ddl",
"CreateFunctionCommand": "ddl",
- "CreateDataSourceTableCommand": "ddl",
- "CreateDataSourceTableAsSelectCommand": "ddl",
"CreateTableLikeCommand": "ddl",
"CreateViewCommand": "ddl",
"DropDatabaseCommand": "ddl",
"DropFunctionCommand": "ddl",
- "NoopDropTable": "ddl",
"DropTableCommand": "ddl",
- "TruncateTableCommand": "ddl",
- "AlterTableRecoverPartitionsCommand": "ddl",
+ "NoopDropTable": "ddl",
"SetCatalogAndNamespace": "ddl",
+ "TruncateTableCommand": "ddl",
Review comment:
TruncateTableCommand
##########
File path:
dev/kyuubi-extension-spark-3-1/src/test/resources/sql-classification-default.json
##########
@@ -1,34 +1,60 @@
{
"AlterDatabasePropertiesCommand": "ddl",
- "AlterTableRenameCommand": "ddl",
- "AlterTableRenamePartitionCommand": "ddl",
"AlterTableAddColumnsCommand": "ddl",
- "AlterTableChangeColumnCommand": "ddl",
"AlterTableAddPartitionCommand": "ddl",
+ "AlterTableChangeColumnCommand": "ddl",
"AlterTableDropPartitionCommand": "ddl",
- "AlterTableSetPropertiesCommand": "ddl",
- "AlterTableSetLocationCommand": "ddl",
- "AlterTableSerDePropertiesCommand": "ddl",
- "AlterTableUnsetPropertiesCommand": "ddl",
+ "AlterTableRecoverPartitionsCommand": "ddl",
+ "AlterTableRenameCommand": "ddl",
"AlterTableRenameCommand": "ddl",
+ "AlterTableRenamePartitionCommand": "ddl",
+ "AlterTableSerDePropertiesCommand": "ddl",
+ "AlterTableSetLocationCommand": "ddl",
"AlterTableSetPropertiesCommand": "ddl",
+ "AlterTableSetPropertiesCommand": "ddl",
+ "AlterTableUnsetPropertiesCommand": "ddl",
"AlterTableUnsetPropertiesCommand": "ddl",
"AlterViewAsCommand": "ddl",
+ "CreateDataSourceTableAsSelectCommand": "ddl",
+ "CreateDataSourceTableCommand": "ddl",
"CreateDatabaseCommand": "ddl",
"CreateFunctionCommand": "ddl",
- "CreateDataSourceTableCommand": "ddl",
- "CreateDataSourceTableAsSelectCommand": "ddl",
"CreateTableLikeCommand": "ddl",
"CreateViewCommand": "ddl",
"DropDatabaseCommand": "ddl",
"DropFunctionCommand": "ddl",
- "NoopDropTable": "ddl",
"DropTableCommand": "ddl",
- "TruncateTableCommand": "ddl",
- "AlterTableRecoverPartitionsCommand": "ddl",
+ "NoopDropTable": "ddl",
"SetCatalogAndNamespace": "ddl",
+ "TruncateTableCommand": "ddl",
+ "InsertIntoDataSourceDirCommand": "dml",
"InsertIntoHadoopFsRelationCommand": "dml",
+ "InsertIntoHiveDirCommand": "dml",
"LoadDataCommand": "dml",
- "InsertIntoDataSourceDirCommand": "dml",
- "InsertIntoHiveDirCommand": "dml"
+ "AddFileCommand": "other",
+ "AddJarCommand": "other",
+ "AnalyzeTable": "other",
Review comment:
AnalyzeColumn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
