yaooqinn commented on a change in pull request #1062:
URL: https://github.com/apache/incubator-kyuubi/pull/1062#discussion_r704478813
##########
File path:
kyuubi-common/src/main/scala/org/apache/kyuubi/operation/log/OperationLog.scala
##########
@@ -134,7 +134,8 @@ class OperationLog(path: Path) extends Logging {
Files.delete(path)
} catch {
case e: IOException =>
- error(s"Failed to remove corresponding log file of operation:
${path.toAbsolutePath}", e)
Review comment:
we can also remove `extend Logging` here, and add some comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
