timothy65535 commented on a change in pull request #1075:
URL: https://github.com/apache/incubator-kyuubi/pull/1075#discussion_r706604281
##########
File path:
externals/kyuubi-spark-sql-engine/src/test/scala/org/apache/kyuubi/engine/spark/events/EventLoggingServiceSuite.scala
##########
@@ -32,7 +32,7 @@ import org.apache.kyuubi.operation.{JDBCTestUtils,
OperationHandle}
class EventLoggingServiceSuite extends WithSparkSQLEngine with JDBCTestUtils {
- private val logRoot = Utils.createTempDir()
+ private val logRoot = "file:" + Utils.createTempDir()
Review comment:
`logRoot` from `Path` type to `String` type, so we don't need to call
`toString` again.
```
private val logRoot = "file:" + Utils.createTempDir()
private val currentDate =
Utils.getDateFromTimestamp(System.currentTimeMillis())
override def withKyuubiConf: Map[String, String] = Map(
KyuubiConf.ENGINE_EVENT_LOGGERS.key -> s"$JSON,$SPARK",
KyuubiConf.ENGINE_EVENT_JSON_LOG_PATH.key -> logRoot.toString,
"spark.eventLog.enabled" -> "true",
"spark.eventLog.dir" -> logRoot.toString
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
