i7xh opened a new pull request #1085:
URL: https://github.com/apache/incubator-kyuubi/pull/1085


   Add MaxOutputRows rule for output rows limitation to avoid huge output 
unexpectedly
   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: 
https://kyuubi.readthedocs.io/en/latest/community/contributions.html
     2. If the PR is related to an issue in 
https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your 
PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
     3. If the PR is unfinished, add
   <img width="1440" alt="截屏2021-09-12 下午12 19 28" 
src="https://user-images.githubusercontent.com/635169/132972063-b12937bb-807a-47bd-8d21-835d83031191.png";>
    '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
   -->
   
   ### _Why are the changes needed?_
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about the use case of it.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   We support the PR feature with limitation that avoid huge output rows in 
user ad-hoc query unexpected,mainly used in below cases:
   
   - CASE 1:
   ``` 
   INSERT OVERWRITE DIRECTORY (path=STRING)?
   USING format OPTIONS ([option1_name "option1_value", option2_name 
"option2_value", ...])
   SELECT ...
   ```
   - CASE 2:
   ```
   SELECT [c1, c2, ...] 
   ```
   - CASE 3:
   ```
   WITH CTE AS (...)
   SELECT [c1, c2, ...] FROM Express(CTE) ...
   ```
   
   ### _How was this patch tested?_
   - [x] Add some test cases that check the changes thoroughly including 
negative and positive cases if possible
   
   - [x] Add screenshots for manual tests if appropriate
   <img width="1440" alt="截屏2021-09-12 下午12 19 28" 
src="https://user-images.githubusercontent.com/635169/132972078-c4821135-0520-420d-9ab8-24e124f6c6c9.png";>
   
   
   - [x] [Run 
test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests)
 locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to