timothy65535 commented on a change in pull request #1060:
URL: https://github.com/apache/incubator-kyuubi/pull/1060#discussion_r706586032
##########
File path:
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/SparkSQLOperationManager.scala
##########
@@ -52,13 +55,21 @@ class SparkSQLOperationManager private (name: String)
extends OperationManager(n
def getOpenSparkSessionCount: Int = sessionToSpark.size()
+ private lazy val operationModeDefault = getConf.get(OPERATION_PLAN_ONLY)
+
override def newExecuteStatementOperation(
session: Session,
statement: String,
runAsync: Boolean,
queryTimeout: Long): Operation = {
val spark = getSparkSession(session.handle)
- val operation = new ExecuteStatement(spark, session, statement, runAsync,
queryTimeout)
+
+ val operationModeStr =
+ spark.conf.get(OPERATION_PLAN_ONLY.key,
operationModeDefault).toUpperCase(Locale.ROOT)
+ val operation = OperationModes.withName(operationModeStr) match {
+ case NONE => new ExecuteStatement(spark, session, statement, runAsync,
queryTimeout)
Review comment:
nit: do we need to consider the following case?
```
set kyuubi.operation.plan.only.mode=abc;
select 1;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
