zhouyifan279 commented on a change in pull request #1074:
URL: https://github.com/apache/incubator-kyuubi/pull/1074#discussion_r707221738



##########
File path: 
kyuubi-server/src/main/scala/org/apache/kyuubi/operation/ExecuteStatement.scala
##########
@@ -120,6 +118,13 @@ class ExecuteStatement(
           val ke = KyuubiSQLException(s"UNKNOWN STATE for $statement")
           setOperationException(ke)
       }
+
+      val appUser = session.asInstanceOf[KyuubiSessionImpl].engine.appUser
+      val sessionManager = 
session.sessionManager.asInstanceOf[KyuubiSessionManager]
+      sessionManager.credentialsManager.sendCredentialsIfNeeded(

Review comment:
       No matter where in `ExecuteStatement#waitStatementComplete` we put the 
send method, there is possibility that Statement has been closed terminated 
when we send credentials.  
   
   Let's make the possibility more obvious.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to