zhang1002 commented on a change in pull request #1136:
URL: https://github.com/apache/incubator-kyuubi/pull/1136#discussion_r714576244
##########
File path:
kyuubi-common/src/main/scala/org/apache/kyuubi/events/JsonEventLogger.scala
##########
@@ -75,7 +75,13 @@ class JsonEventLogger[T <: KyuubiEvent](logName: String,
}
private def requireLogRootWritable(): Unit = {
- val fileStatus = fs.getFileStatus(new Path(logRoot))
+ val fileStatus = try {
+ fs.getFileStatus(new Path(logRoot))
+ } catch {
+ case e: IOException =>
+ error(s"Get log directory $logRoot failed", e)
Review comment:
Yes, we cannot log this exception.
Before fix this bug, when the dir is not exist, the engineLog only can get:
java.lang.IllegalStateException: Illegal Service State: LATENT.
The cause of this exception is:
when we stop the engine before, we need to get this engine's
engineStatus(SparkSQLEngine line 158).
this engineStatus will store the connectionUrl from frontendService. But if
this serviceState is LATENT, it will throw this exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
