ulysses-you commented on a change in pull request #1140:
URL: https://github.com/apache/incubator-kyuubi/pull/1140#discussion_r714627441
##########
File path:
dev/kyuubi-extension-spark-3-1/src/main/scala/org/apache/kyuubi/sql/sqlclassification/KyuubiGetSqlClassification.scala
##########
@@ -35,28 +35,25 @@ import org.apache.kyuubi.sql.KyuubiSQLConf._
* If there have no this named jsonFile,
* the service will upload the default matching rule:
sql-classification-default.json.
*/
-object KyuubiGetSqlClassification {
-
+object KyuubiGetSqlClassification extends Logging {
private val jsonNode: Option[JsonNode] = {
SQLConf.get.getConf(SQL_CLASSIFICATION_ENABLED) match {
case true =>
val objectMapper = new ObjectMapper
- var url: URL = Thread.currentThread().getContextClassLoader
- .getResource("sql-classification.json")
+ var url: URL =
getClass.getClassLoader.getResource("sql-classification.json")
Review comment:
It's better to keep these consistent, user can still specify the custom
config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
