yaooqinn commented on a change in pull request #1160:
URL: https://github.com/apache/incubator-kyuubi/pull/1160#discussion_r716161311
##########
File path:
kyuubi-common/src/main/scala/org/apache/kyuubi/operation/log/OperationLog.scala
##########
@@ -25,16 +25,26 @@ import java.nio.file.{Files, Path, Paths}
import org.apache.hive.service.rpc.thrift.{TColumn, TRow, TRowSet,
TStringColumn}
import org.apache.kyuubi.{KyuubiSQLException, Logging, Utils}
+import org.apache.kyuubi.config.KyuubiConf
+import org.apache.kyuubi.config.KyuubiConf.{ENGINE_OPERATION_LOG_DIR_ROOT,
SERVER_OPERATION_LOG_DIR_ROOT}
import org.apache.kyuubi.operation.OperationHandle
import org.apache.kyuubi.session.SessionHandle
object OperationLog extends Logging {
+ val conf = KyuubiConf()
- def LOG_ROOT: String = if (Utils.isTesting) {
- "target/operation_logs"
+ def SERVER_LOG_ROOT: String = if (Utils.isTesting) {
Review comment:
move this to session managers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
