timothy65535 commented on a change in pull request #1119:
URL: https://github.com/apache/incubator-kyuubi/pull/1119#discussion_r716228753
##########
File path:
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/ProcBuilder.scala
##########
@@ -49,18 +48,9 @@ trait ProcBuilder {
protected def env: Map[String, String] = conf.getEnvs
- protected val workingDir: Path
-
- final lazy val processBuilder: ProcessBuilder = {
- val pb = new ProcessBuilder(commands: _*)
+ protected def launcher: SparkLauncher
Review comment:
Probably not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
