zhang1002 commented on a change in pull request #1154:
URL: https://github.com/apache/incubator-kyuubi/pull/1154#discussion_r716339998
##########
File path:
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkSQLEngine.scala
##########
@@ -65,8 +65,10 @@ case class SparkSQLEngine(spark: SparkSession) extends
Serverable("SparkSQLEngin
}
override def stop(): Unit = {
- eventLogging.onEvent(
- engineStatus.copy(state = ServiceState.STOPPED.id, endTime =
System.currentTimeMillis()))
+ if (!state.equals(ServiceState.LATENT)) {
Review comment:
i think state judgement should in the method of
JsonEventLogger.getOrUpdate.
only "STARTED" state can provided this service.
this need @yaooqinn to confirm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
