yaooqinn commented on a change in pull request #1153:
URL: https://github.com/apache/incubator-kyuubi/pull/1153#discussion_r716343994
##########
File path:
kyuubi-common/src/main/scala/org/apache/kyuubi/events/JsonEventLogger.scala
##########
@@ -75,6 +75,15 @@ class JsonEventLogger[T <: KyuubiEvent](logName: String,
}
private def requireLogRootWritable(): Unit = {
+ // Create logRoot
+ // Here should notice, if the user has no permission, it will throw
exception
+ try {
+ FileSystem.mkdirs(fs, new Path(logRoot), JSON_LOG_DIR_PERM)
Review comment:
LogRoot probably shares across users, is it good practice that making it
be created by one single user?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
