yaooqinn commented on a change in pull request #1160:
URL: https://github.com/apache/incubator-kyuubi/pull/1160#discussion_r716348698



##########
File path: 
kyuubi-common/src/main/scala/org/apache/kyuubi/session/SessionManager.scala
##########
@@ -41,6 +43,20 @@ abstract class SessionManager(name: String) extends 
CompositeService(name) {
 
   @volatile private var shutdown = false
 
+  protected var _operationLogRoot: String = null
+
+  def operationLogRoot: String = _operationLogRoot
+
+  private def initOperationLogRootDir(): Unit = {

Review comment:
       maybe we can make operationLogRoot an Option[String], if we fail to 
initialize the _operationLogRoot, then we don't initialize the OperationLog for 
operations and just return the result




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to