ulysses-you commented on a change in pull request #1119:
URL: https://github.com/apache/incubator-kyuubi/pull/1119#discussion_r719234616
##########
File path:
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/ProcBuilder.scala
##########
@@ -148,6 +149,23 @@ trait ProcBuilder {
proc
}
+ val YARN_APP_NAME_REGEX: Regex = "application_\\d+_\\d+".r
+
+ def killApplication(line: String = lastRowOfLog): Int =
Review comment:
can we return msg here directly and move following code into this method
?
```
val killMessage = builder.killApplication() match {
case id if id != 0 => "And failed to kill Application, please kill it
manually. "
case _ => "And killed Application successfully. "
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
