i7xh commented on a change in pull request #1129:
URL: https://github.com/apache/incubator-kyuubi/pull/1129#discussion_r721951386
##########
File path:
dev/kyuubi-extension-spark-3-1/src/main/scala/org/apache/kyuubi/sql/watchdog/ForcedMaxOutputRowsRule.scala
##########
@@ -49,8 +50,12 @@ case class ForcedMaxOutputRowsRule(session: SparkSession)
extends Rule[LogicalPl
maxOutputRowsOpt match {
case Some(forcedMaxOutputRows) => val supported = p match {
+ case agg: Aggregate => agg match {
+ case Aggregate(_, Alias(_, "havingCondition")::Nil, _) => false
Review comment:
It's difficulty to process the situation according the order , because
aggregate function will be called nested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
