This is an automated email from the ASF dual-hosted git repository.
chengpan pushed a commit to branch branch-1.3
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git
The following commit(s) were added to refs/heads/branch-1.3 by this push:
new 53addb6 [KYUUBI #1290] Reset kinit attempt number once the command
execute successfully to prevent transient error accumulation
53addb6 is described below
commit 53addb62c5057510d577fcadd688ee9878d213f4
Author: fwang12 <[email protected]>
AuthorDate: Mon Oct 25 22:37:34 2021 +0800
[KYUUBI #1290] Reset kinit attempt number once the command execute
successfully to prevent transient error accumulation
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in
https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your
PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
Reset attempt number after kinit successfully to prevent transient error
accumulation and fail the server.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including
negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run
test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests)
locally before make a pull request
Closes #1290 from turboFei/kinit_recover.
Closes #1290
c40c2fa6 [fwang12] Reset kinitMaxAttempts to 0 once the kinit command
execute successfully to prevent transient error
Authored-by: fwang12 <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
(cherry picked from commit 2675e9a80daaf5c965f57d956fb41541f4756828)
Signed-off-by: Cheng Pan <[email protected]>
---
.../src/main/scala/org/apache/kyuubi/service/KinitAuxiliaryService.scala | 1 +
1 file changed, 1 insertion(+)
diff --git
a/kyuubi-common/src/main/scala/org/apache/kyuubi/service/KinitAuxiliaryService.scala
b/kyuubi-common/src/main/scala/org/apache/kyuubi/service/KinitAuxiliaryService.scala
index a44738d..0b719d1 100644
---
a/kyuubi-common/src/main/scala/org/apache/kyuubi/service/KinitAuxiliaryService.scala
+++
b/kyuubi-common/src/main/scala/org/apache/kyuubi/service/KinitAuxiliaryService.scala
@@ -51,6 +51,7 @@ class KinitAuxiliaryService() extends
AbstractService("KinitAuxiliaryService") {
val process = kinitProc.start()
if (process.waitFor() == 0) {
info(s"Successfully ${commands.mkString(" ")}")
+ kinitAttempts = 0
executor.schedule(this, kinitInterval, TimeUnit.MILLISECONDS)
} else {
if (kinitAttempts >= kinitMaxAttempts) {
