yanghua commented on a change in pull request #1298:
URL: https://github.com/apache/incubator-kyuubi/pull/1298#discussion_r737971418
##########
File path:
kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/SessionsResourceSuite.scala
##########
@@ -73,57 +70,59 @@ class SessionsResourceSuite extends RestApiBaseSuite {
// close a opened session
val serializedSessionHandle = s"${sessionHandle.identifier.publicId}|"
+
s"${sessionHandle.identifier.secretId}|${sessionHandle.protocol.getValue}"
- response =
target(s"api/v1/sessions/$serializedSessionHandle").request().delete()
+ response = webTarget.path(s"api/v1/sessions/$serializedSessionHandle")
+ .request().delete()
assert(200 == response.getStatus)
// verify the open session count again
- response = target("api/v1/sessions/count").request().get()
+ response = webTarget.path("api/v1/sessions/count").request().get()
val openedSessionCount = response.readEntity(classOf[SessionOpenCount])
assert(openedSessionCount.openSessionCount == 0)
}
}
- @Test
- def testExecPoolStatistic: Unit = {
+ test("test execPoolStatistic") {
RestFrontendServiceSuite.withKyuubiRestServer {
- (restFrontendService: RestFrontendService, _, _) =>
+ (restFrontendService: RestFrontendService, _, _, webTarget) =>
val sessionManager = restFrontendService.be.sessionManager
val future = sessionManager.submitBackgroundOperation(() => {
Thread.sleep(3000)
})
// verify the exec pool statistic
- var response =
target("api/v1/sessions/execpool/statistic").request().get()
+ var response = webTarget.path("api/v1/sessions/execpool/statistic")
+ .request().get()
val execPoolStatistic1 =
response.readEntity(classOf[ExecPoolStatistic])
assert(execPoolStatistic1.execPoolSize == 1 &&
execPoolStatistic1.execPoolActiveCount == 1)
future.cancel(true)
- response = target("api/v1/sessions/execpool/statistic").request().get()
+ response = webTarget.path("api/v1/sessions/execpool/statistic")
+ .request().get()
Review comment:
ditto, and check others?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
