zhouyifan279 commented on a change in pull request #1312:
URL: https://github.com/apache/incubator-kyuubi/pull/1312#discussion_r739973940
##########
File path:
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkThriftBinaryFrontendService.scala
##########
@@ -147,6 +147,15 @@ class SparkThriftBinaryFrontendService(
s"${serverAddr.getHostAddress}:$portNum"
}
}
+
+ // When a OOM occurs, here we de-register the engine by stop its
discoveryService.
+ // Then the current engine will not be connected by new client anymore but
keep the existing ones
+ // alive. In this case we can reduce the engine's overhead and make it
possible recover from that.
+ // We shall not tear down the whole engine by serverable.stop to make the
engine unreachable for
+ // the exising clients which are still get statuses and report the end-users.
Review comment:
1. `exising` -> `existing`
2. `report the end-users` -> `report to the end-users`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
