leo65535 commented on a change in pull request #908:
URL: https://github.com/apache/incubator-kyuubi/pull/908#discussion_r741574285
##########
File path:
kyuubi-server/src/main/scala/org/apache/kyuubi/server/EventLoggingService.scala
##########
@@ -48,9 +62,23 @@ class EventLoggingService extends
AbstractEventLoggingService[KyuubiServerEvent]
// TODO: Add more implementations
throw new IllegalArgumentException(s"Unrecognized event logger:
$logger")
}
+
+ // load audit logger
+ if (conf.get(AUDIT_LOG_ENABLE)) {
+ val jsonAuditLogger = new
JsonEventLogger[KyuubiServerEvent](s"server-$hostName",
+ SERVER_AUDIT_EVENT_JSON_LOG_PATH, new Configuration())
+ jsonAuditLogger.createEventLogRootDir(conf,
KyuubiHadoopUtils.newHadoopConf(conf))
+ addService(jsonAuditLogger)
Review comment:
the `jsonAuditLogger` is transfered two places seems not a good practice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
