hddong commented on a change in pull request #1325:
URL: https://github.com/apache/incubator-kyuubi/pull/1325#discussion_r741592456
##########
File path: docker/helm/values.yaml
##########
@@ -41,4 +41,16 @@ service:
# to change:
# vim kube-apiserver.yaml (usually under path: /etc/kubernetes/manifests/)
# add or change line 'service-node-port-range=1-32767' under kube-apiserver
- port: 30009
\ No newline at end of file
+ port: 30009
+
+resources: {}
+ # Used to specify resource, default unlimited.
+ # If you do want to specify resources:
+ # 1. remove the curly braces after 'resources:'
+ # 2. uncomment the following lines
+ # limits:
+ # cpu: 4
+ # memory: 10Gi
+ # requests:
+ # cpu: 2
+ # memory: 4Gi
Review comment:
Done
##########
File path: docker/helm/templates/kyuubi-deployment.yaml
##########
@@ -46,6 +46,8 @@ spec:
- name: frontend-port
containerPort: {{ .Values.server.bind.port }}
protocol: TCP
+ resources:
+ {{- toYaml .Values.resources | nindent 12 }}
Review comment:
> shall we use `indent` rather than `nindent` here ? otherwise we will
get a new empty line. I just read some [related
docs](https://helm.sh/docs/chart_template_guide/function_list/#nindent).
It seems that it must be `nindent` here, if use `indent`, we will get error
` mapping values are not allowed in this context`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
