yaooqinn commented on a change in pull request #1326:
URL: https://github.com/apache/incubator-kyuubi/pull/1326#discussion_r741787215
##########
File path:
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
##########
@@ -758,6 +758,21 @@ object KyuubiConf {
.version("1.2.0")
.fallbackConf(LEGACY_ENGINE_SHARE_LEVEL)
+ val ENGINE_TYPE: ConfigEntry[String] = buildConf("engine.type")
+ .doc("Specify the detailed engine that supported by the Kyuubi. The engine
type bindings to" +
+ " SESSION scope. Currently, available configs are: <ul>" +
Review comment:
let's add `This configuration is experimental.`
##########
File path:
kyuubi-common/src/main/scala/org/apache/kyuubi/engine/EngineType.scala
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kyuubi.engine
+
+/**
+ * Defines different engine types supported by Kyuubi.
+ */
+object EngineType extends Enumeration {
+ type EngineType = Value
+ val
+ SPARK_SQL,
+ FLINK_SQL = Value
Review comment:
Let's follow this scala style
* An enumeration class or object which extends the Enumeration class shall
follow the convention for classes and objects, i.e. its name should be in
PascalCase style. Enumeration values shall be in the upper case with words
separated by the underscore character _. For example:
```scala
private object ParseState extends Enumeration {
type ParseState = Value
val PREFIX,
TRIM_BEFORE_SIGN,
SIGN,
TRIM_BEFORE_VALUE,
VALUE,
VALUE_FRACTIONAL_PART,
TRIM_BEFORE_UNIT,
UNIT_BEGIN,
UNIT_SUFFIX,
UNIT_END = Value
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
