yaooqinn commented on a change in pull request #1333:
URL: https://github.com/apache/incubator-kyuubi/pull/1333#discussion_r743354750
##########
File path:
dev/kyuubi-extension-spark-common/src/main/scala/org/apache/kyuubi/sql/zorder/ZorderBase.scala
##########
@@ -43,46 +43,46 @@ abstract class ZorderBase extends Expression {
}
@transient
- private lazy val defaultNullValues: Array[Array[Byte]] =
+ private lazy val defaultNullValues: Array[Any] =
children.map(_.dataType)
.map(ZorderBytesUtils.defaultValue)
.toArray
override def eval(input: InternalRow): Any = {
- val binaryArr = children.zipWithIndex.map {
+ val childrenValues = children.zipWithIndex.map {
Review comment:
shall we also improve the non-codegen part perf？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
