pan3793 commented on a change in pull request #1339: URL: https://github.com/apache/incubator-kyuubi/pull/1339#discussion_r743478887
########## File path: docs/develop_tools/building.md ########## @@ -73,21 +73,21 @@ Profile | Default | Since -Pspark-3.1 | No | 1.1.0 -## Defining the Apache Mirror for Spark +## Defining the Apache Mirror for Spark or Flink -By default, we use `https://archive.apache.org/dist/spark/` to download the built-in Spark release package, +By default, we use `https://archive.apache.org/dist/spark/` to download the built-in Spark or Flink release package, Review comment: url ########## File path: docs/develop_tools/building.md ########## @@ -73,21 +73,21 @@ Profile | Default | Since -Pspark-3.1 | No | 1.1.0 -## Defining the Apache Mirror for Spark +## Defining the Apache Mirror for Spark or Flink -By default, we use `https://archive.apache.org/dist/spark/` to download the built-in Spark release package, +By default, we use `https://archive.apache.org/dist/spark/` to download the built-in Spark or Flink release package, but if you find it hard to reach, or the downloading speed is too slow, you can define the `spark.archive.mirror` -property to a suitable Apache mirror site. For instance, +or `flink.archive.mirror` property to a suitable Apache mirror site. For instance, ```bash build/mvn clean package -Dspark.archive.mirror=https://mirrors.bfsu.edu.cn/apache/spark/spark-3.0.1 ``` Visit [Apache Mirrors](http://www.apache.org/mirrors/) and choose a mirror based on your region. -Specifically for developers in China mainland, you can use the pre-defined profile named `mirror-cn` which use -`mirrors.bfsu.edu.cn` to speed up Spark Binary downloading. For instance, +Specifically for developers in China mainland, you can use the pre-defined profile named `spark-mirror-cn` +or `flink-mirror-cn` which use `mirrors.bfsu.edu.cn` to speed up Spark Binary downloading. For instance, Review comment: `mirror-cn` for two is enough? ########## File path: pom.xml ########## @@ -123,6 +123,10 @@ <spark.archive.name>spark-${spark.version}-bin-hadoop${hadoop.binary.version}.tgz</spark.archive.name> <spark.archive.mirror>https://archive.apache.org/dist/spark/spark-${spark.version}</spark.archive.mirror> <spark.archive.download.skip>false</spark.archive.download.skip> + <flink.version>1.12.5</flink.version> Review comment: to L100, sort alphabetically -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
