murong00 commented on a change in pull request #1359:
URL: https://github.com/apache/incubator-kyuubi/pull/1359#discussion_r747132770
##########
File path:
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiServer.scala
##########
@@ -42,6 +47,35 @@ object KyuubiServer extends Logging {
zkServer.start()
conf.set(HA_ZK_QUORUM, zkServer.getConnectString)
conf.set(HA_ZK_AUTH_TYPE, ZooKeeperAuthTypes.NONE.toString)
+ } else {
+ // create chroot path if necessary
+ val connectionStr = conf.get(HA_ZK_QUORUM)
+ val chrootIndex = connectionStr.indexOf("/")
Review comment:
> `connectionStr` is a comma-separated list of servers to connect to.
>
> ```
> localhost:2181/lakehouse,localhost:2181/lakehouse
> localhost:2181/lakehouse,localhost:2181
> localhost:2181,localhost:2181/lakehouse
> ```
>
> Are we able to handle all these valid and invalid cases?
In general, the third one is recommended and used, so I think we only need
to support this and we can provide an example to cover this case in parameter
document.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
