pan3793 commented on a change in pull request #1376:
URL: https://github.com/apache/incubator-kyuubi/pull/1376#discussion_r748827704
##########
File path:
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiMySQLFrontendService.scala
##########
@@ -77,7 +79,11 @@ class KyuubiMySQLFrontendService(override val serverable:
Serverable)
.childHandler(new ChannelInitializer[SocketChannel] {
override def initChannel(channel: SocketChannel): Unit =
channel.pipeline
.addLast(new LoggingHandler("org.apache.kyuubi.server.mysql.codec",
LogLevel.TRACE))
- // TODO implement authentication, codec, command handler
+ .addLast(new MySQLFrameDelimiter)
+ .addLast(new MySQLPacketEncoder)
+ .addLast(new MySQLAuthHandler)
+ .addLast(new MySQLPacketDecoder)
+ .addLast(new MySQLCommandHandler(serverable.backendService,
execPool))
Review comment:
The netty pipeline can be an entrypoint of this PR for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
