yaooqinn commented on a change in pull request #1381: URL: https://github.com/apache/incubator-kyuubi/pull/1381#discussion_r749028583
########## File path: kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/HttpKerberosRequestInterceptor.java ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kyuubi.jdbc.hive; + +import java.util.Map; +import java.util.concurrent.locks.ReentrantLock; + +import org.apache.hive.service.auth.HttpAuthUtils; +import org.apache.http.HttpException; +import org.apache.http.HttpRequest; +import org.apache.http.client.CookieStore; +import org.apache.http.protocol.HttpContext; + +/** + * Authentication interceptor which adds Base64 encoded payload, + * containing the username and kerberos service ticket, + * to the outgoing http request header. + */ +public class HttpKerberosRequestInterceptor extends HttpRequestInterceptorBase { + + String principal; + String host; + String serverHttpUrl; + boolean assumeSubject; + + // A fair reentrant lock + private static ReentrantLock kerberosLock = new ReentrantLock(true); + + public HttpKerberosRequestInterceptor(String principal, String host, + String serverHttpUrl, boolean assumeSubject, CookieStore cs, String cn, + boolean isSSL, Map<String, String> additionalHeaders) { + super(cs, cn, isSSL, additionalHeaders); + this.principal = principal; + this.host = host; + this.serverHttpUrl = serverHttpUrl; + this.assumeSubject = assumeSubject; + } + + @Override + protected void addHttpAuthHeader(HttpRequest httpRequest, + HttpContext httpContext) throws Exception { + try { + // Generate the service ticket for sending to the server. + // Locking ensures the tokens are unique in case of concurrent requests + kerberosLock.lock(); + String kerberosAuthHeader = HttpAuthUtils.getKerberosServiceTicket( + principal, host, serverHttpUrl, assumeSubject); + // Set the session key token (Base64 encoded) in the headers + httpRequest.addHeader(HttpAuthUtils.AUTHORIZATION + ": " + + HttpAuthUtils.NEGOTIATE + " ", kerberosAuthHeader); + } catch (Exception e) { + throw new HttpException(e.getMessage(), e); + } finally { + kerberosLock.unlock(); + } + } +} Review comment: nit ########## File path: kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/HttpBasicAuthInterceptor.java ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kyuubi.jdbc.hive; + +import java.util.Map; + +import org.apache.http.Header; +import org.apache.http.HttpRequest; +import org.apache.http.auth.UsernamePasswordCredentials; +import org.apache.http.client.CookieStore; +import org.apache.http.impl.auth.AuthSchemeBase; +import org.apache.http.impl.auth.BasicScheme; +import org.apache.http.protocol.HttpContext; + +/** + * The class is instantiated with the username and password, it is then + * used to add header with these credentials to HTTP requests + * + */ +public class HttpBasicAuthInterceptor extends HttpRequestInterceptorBase { + UsernamePasswordCredentials credentials; + AuthSchemeBase authScheme; + + public HttpBasicAuthInterceptor(String username, String password, CookieStore cookieStore, + String cn, boolean isSSL, Map<String, String> additionalHeaders) { + super(cookieStore, cn, isSSL, additionalHeaders); + this.authScheme = new BasicScheme(); + if (username != null){ + this.credentials = new UsernamePasswordCredentials(username, password); + } + } + + @Override + protected void addHttpAuthHeader(HttpRequest httpRequest, HttpContext httpContext) + throws Exception { + Header basicAuthHeader = authScheme.authenticate(credentials, httpRequest, httpContext); + httpRequest.addHeader(basicAuthHeader); + } +} Review comment: nit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
