pan3793 commented on a change in pull request #1400:
URL: https://github.com/apache/incubator-kyuubi/pull/1400#discussion_r750356607



##########
File path: 
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiConnection.java
##########
@@ -164,7 +172,7 @@ public KyuubiConnection(String uri, Properties info) throws 
SQLException {
 
       // open client session
       openSession();
-      getLaunchEngineLog();
+      showLaunchEngineLog();

Review comment:
       The kyuubi jdbc driver should not intent to support `EmbeddedMode`?
   
   If yes, can we check `isEmbeddedMode`'s value and throw exception if it is 
`true`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to