pan3793 commented on a change in pull request #1400:
URL: https://github.com/apache/incubator-kyuubi/pull/1400#discussion_r750369119
##########
File path:
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiConnection.java
##########
@@ -220,32 +229,71 @@ public KyuubiConnection(String uri, Properties info)
throws SQLException {
client = newSynchronizedClient(client);
}
- private void getLaunchEngineLog() {
+ /**
+ * Check whether launch engine operation might be producing more logs to be
fetched.
+ * This method is a public API for usage outside of Kyuubi, although it is
not part of the
+ * interface java.sql.Connection.
+ * @return true if launch engine operation might be producing more logs. It
does not indicate
+ * if last log lines have been fetched by getEngineLog.
+ */
+ public boolean hasMoreEngineLogs() {
+ return launchEngineOpHandle != null && !(launchEngineOpCompleted &&
!isEngineLogBeingGenerated);
Review comment:
Maybe write as `launchEngineOpHandle != null &&
(isEngineLogBeingGenerated || !launchEngineOpCompleted)` is more readable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
