pan3793 opened a new pull request #1402:
URL: https://github.com/apache/incubator-kyuubi/pull/1402
### _Why are the changes needed?_
Fix #1293
We have to options to fix this issue. This PR implement the option 2.
```
[option 1]
kyuubi.engine.share.level.subdomain: String -- default: "default"
kyuubi.engine.pool.size: Int -- default: -1
val subdomain =
if (kyuubi.engine.share.level.subdomain == "default" &&
kyuubi.engine.pool.size > 0) {
s"engine-pool-[num]"
} else {
kyuubi.engine.share.level.subdomain
}
[option 2]
kyuubi.engine.share.level.subdomain: Option[String] -- default: None
kyuubi.engine.pool.size: Int -- default: -1
val subdomain =
kyuubi.engine.share.level.subdomain match {
case Some(value) => value
case None if kyuubi.engine.pool.size > 0 => s"engine-pool-[num]"
case None => "default"
}
```
```
[diff]
[[case1]]
kyuubi.engine.share.level.subdomain=default
kyuubi.engine.pool.size=2
option 1 result: subdomain="engine-pool-[num]"
option 2 result: subdomain="default"
[[case2]]
kyuubi.engine.share.level.subdomain=hello
kyuubi.engine.pool.size=2
option 1 result: subdomain="hello"
option 2 result: subdomain="hello"
[[case3]]
kyuubi.engine.share.level.subdomain=
kyuubi.engine.pool.size=2
option 1 result: subdomain="engine-pool-[num]"
option 2 result: subdomain="engine-pool-[num]"
[[case4]]
kyuubi.engine.share.level.subdomain=
kyuubi.engine.pool.size=
option 1 result: subdomain="default"
option 2 result: subdomain="default"
[[case5]]
kyuubi.engine.share.level.subdomain="hello"
kyuubi.engine.pool.size=
option 1 result: subdomain="hello"
option 2 result: subdomain="hello"
```
### _How was this patch tested?_
- [x] Add some test cases that check the changes thoroughly including
negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run
test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests)
locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
