pan3793 commented on a change in pull request #1413:
URL: https://github.com/apache/incubator-kyuubi/pull/1413#discussion_r752167903
##########
File path: kyuubi-assembly/pom.xml
##########
@@ -94,6 +94,18 @@
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>jline</groupId>
+ <artifactId>jline</artifactId>
+ <version>${jline.version}</version>
+ <exclusions>
+ <exclusion>
+ <artifactId>junit</artifactId>
+ <groupId>junit</groupId>
+ </exclusion>
+ </exclusions>
+ </dependency>
Review comment:
Sorry, I just notice you pin `<version>` and `<exclusions>` directly in
child pom `<dependencies>` block, could you please move them to root pom
`<dependencyManagement>` block? @murong00
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
