This is an automated email from the ASF dual-hosted git repository.
chengpan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git
The following commit(s) were added to refs/heads/master by this push:
new 4a9a853 [KYUUBI #1181] [BUG] Format file paths to specifications.
4a9a853 is described below
commit 4a9a853e69c44f8ac0818936f71a4256b404cc66
Author: Jagadesh Adireddi <[email protected]>
AuthorDate: Sat Nov 20 14:26:39 2021 +0800
[KYUUBI #1181] [BUG] Format file paths to specifications.
Issue: https://github.com/apache/incubator-kyuubi/issues/1181
### _Why are the changes needed?_
Format file paths of local path and hdfs path to specifications
Closes #1420 from jadireddi/1181-Format.
Closes #1181
32aacc7f [Jagadesh Adireddi] update doc
679369ea [Jagadesh Adireddi] [KYUUBI #1181] [BUG] Format file paths to
specifications.
Authored-by: Jagadesh Adireddi <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
---
docs/deployment/settings.md | 4 ++--
.../src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala | 10 ++++------
2 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/docs/deployment/settings.md b/docs/deployment/settings.md
index 39bc402..4f342d1 100644
--- a/docs/deployment/settings.md
+++ b/docs/deployment/settings.md
@@ -142,7 +142,7 @@
kyuubi\.backend\.engine<br>\.exec\.pool\.keepalive<br>\.time|<div style='width:
kyuubi\.backend\.engine<br>\.exec\.pool\.shutdown<br>\.timeout|<div
style='width: 65pt;word-wrap: break-word;white-space: normal'>PT10S</div>|<div
style='width: 170pt;word-wrap: break-word;white-space: normal'>Timeout(ms) for
the operation execution thread pool to terminate in SQL engine
applications</div>|<div style='width: 30pt'>duration</div>|<div style='width:
20pt'>1.0.0</div>
kyuubi\.backend\.engine<br>\.exec\.pool\.size|<div style='width:
65pt;word-wrap: break-word;white-space: normal'>100</div>|<div style='width:
170pt;word-wrap: break-word;white-space: normal'>Number of threads in the
operation execution thread pool of SQL engine applications</div>|<div
style='width: 30pt'>int</div>|<div style='width: 20pt'>1.0.0</div>
kyuubi\.backend\.engine<br>\.exec\.pool\.wait\.queue<br>\.size|<div
style='width: 65pt;word-wrap: break-word;white-space: normal'>100</div>|<div
style='width: 170pt;word-wrap: break-word;white-space: normal'>Size of the wait
queue for the operation execution thread pool in SQL engine
applications</div>|<div style='width: 30pt'>int</div>|<div style='width:
20pt'>1.0.0</div>
-kyuubi\.backend\.server<br>\.event\.json\.log\.path|<div style='width:
65pt;word-wrap: break-word;white-space: normal'>/tmp/kyuubi/events</div>|<div
style='width: 170pt;word-wrap: break-word;white-space: normal'>The location of
server events go for the builtin JSON logger</div>|<div style='width:
30pt'>string</div>|<div style='width: 20pt'>1.4.0</div>
+kyuubi\.backend\.server<br>\.event\.json\.log\.path|<div style='width:
65pt;word-wrap: break-word;white-space:
normal'>file:///tmp/kyuubi/events</div>|<div style='width: 170pt;word-wrap:
break-word;white-space: normal'>The location of server events go for the
builtin JSON logger</div>|<div style='width: 30pt'>string</div>|<div
style='width: 20pt'>1.4.0</div>
kyuubi\.backend\.server<br>\.event\.loggers|<div style='width: 65pt;word-wrap:
break-word;white-space: normal'></div>|<div style='width: 170pt;word-wrap:
break-word;white-space: normal'>A comma separated list of server history
loggers, where session/operation etc events go.<ul> <li>JSON: the events will
be written to the location of kyuubi.backend.server.event.json.log.path</li>
<li>JDBC: to be done</li> <li>CUSTOM: to be done.</li></ul></div>|<div
style='width: 30pt'>seq</div>|<div styl [...]
kyuubi\.backend\.server<br>\.exec\.pool\.keepalive<br>\.time|<div
style='width: 65pt;word-wrap: break-word;white-space: normal'>PT1M</div>|<div
style='width: 170pt;word-wrap: break-word;white-space: normal'>Time(ms) that an
idle async thread of the operation execution thread pool will wait for a new
task to arrive before terminating in Kyuubi server</div>|<div style='width:
30pt'>duration</div>|<div style='width: 20pt'>1.0.0</div>
kyuubi\.backend\.server<br>\.exec\.pool\.shutdown<br>\.timeout|<div
style='width: 65pt;word-wrap: break-word;white-space: normal'>PT10S</div>|<div
style='width: 170pt;word-wrap: break-word;white-space: normal'>Timeout(ms) for
the operation execution thread pool to terminate in Kyuubi server</div>|<div
style='width: 30pt'>duration</div>|<div style='width: 20pt'>1.0.0</div>
@@ -180,7 +180,7 @@ kyuubi\.engine<br>\.deregister\.exception<br>\.classes|<div
style='width: 65pt;w
kyuubi\.engine<br>\.deregister\.exception<br>\.messages|<div style='width:
65pt;word-wrap: break-word;white-space: normal'></div>|<div style='width:
170pt;word-wrap: break-word;white-space: normal'>A comma separated list of
exception messages. If there is any exception thrown, whose message or
stacktrace matches the specified message list, the engine would deregister
itself.</div>|<div style='width: 30pt'>seq</div>|<div style='width:
20pt'>1.2.0</div>
kyuubi\.engine<br>\.deregister\.exception<br>\.ttl|<div style='width:
65pt;word-wrap: break-word;white-space: normal'>PT30M</div>|<div style='width:
170pt;word-wrap: break-word;white-space: normal'>Time to live(TTL) for
exceptions pattern specified in kyuubi.engine.deregister.exception.classes and
kyuubi.engine.deregister.exception.messages to deregister engines. Once the
total error count hits the kyuubi.engine.deregister.job.max.failures within the
TTL, an engine will deregister itself [...]
kyuubi\.engine<br>\.deregister\.job\.max<br>\.failures|<div style='width:
65pt;word-wrap: break-word;white-space: normal'>4</div>|<div style='width:
170pt;word-wrap: break-word;white-space: normal'>Number of failures of job
before deregistering the engine.</div>|<div style='width: 30pt'>int</div>|<div
style='width: 20pt'>1.2.0</div>
-kyuubi\.engine\.event<br>\.json\.log\.path|<div style='width: 65pt;word-wrap:
break-word;white-space: normal'>file:/tmp/kyuubi/events</div>|<div
style='width: 170pt;word-wrap: break-word;white-space: normal'>The location of
all the engine events go for the builtin JSON logger.<ul><li>Local Path: start
with 'file:'</li><li>HDFS Path: start with 'hdfs:'</li></ul></div>|<div
style='width: 30pt'>string</div>|<div style='width: 20pt'>1.3.0</div>
+kyuubi\.engine\.event<br>\.json\.log\.path|<div style='width: 65pt;word-wrap:
break-word;white-space: normal'>file:///tmp/kyuubi/events</div>|<div
style='width: 170pt;word-wrap: break-word;white-space: normal'>The location of
all the engine events go for the builtin JSON logger.<ul><li>Local Path: start
with 'file://'</li><li>HDFS Path: start with 'hdfs://'</li></ul></div>|<div
style='width: 30pt'>string</div>|<div style='width: 20pt'>1.3.0</div>
kyuubi\.engine\.event<br>\.loggers|<div style='width: 65pt;word-wrap:
break-word;white-space: normal'>SPARK</div>|<div style='width: 170pt;word-wrap:
break-word;white-space: normal'>A comma separated list of engine history
loggers, where engine/session/operation etc events go. We use spark logger by
default.<ul> <li>SPARK: the events will be written to the spark listener
bus.</li> <li>JSON: the events will be written to the location of
kyuubi.engine.event.json.log.path</li> <li>JDBC: to [...]
kyuubi\.engine<br>\.initialize\.sql|<div style='width: 65pt;word-wrap:
break-word;white-space: normal'>SHOW DATABASES</div>|<div style='width:
170pt;word-wrap: break-word;white-space: normal'>SemiColon-separated list of
SQL statements to be initialized in the newly created engine before queries.
i.e. use `SHOW DATABASES` to eagerly active HiveClient. This configuration can
not be used in JDBC url due to the limitation of Beeline/JDBC
driver.</div>|<div style='width: 30pt'>seq</div>|<div [...]
kyuubi\.engine<br>\.operation\.log\.dir<br>\.root|<div style='width:
65pt;word-wrap: break-word;white-space:
normal'>engine_operation_logs</div>|<div style='width: 170pt;word-wrap:
break-word;white-space: normal'>Root directory for query operation log at
engine-side.</div>|<div style='width: 30pt'>string</div>|<div style='width:
20pt'>1.4.0</div>
diff --git
a/kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
b/kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
index 2ad1368..21e3d7e 100644
--- a/kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
+++ b/kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
@@ -943,23 +943,21 @@ object KyuubiConf {
.booleanConf
.createWithDefault(false)
- // TODO: #1181 Format does not conform to specifications
val SERVER_EVENT_JSON_LOG_PATH: ConfigEntry[String] =
buildConf("backend.server.event.json.log.path")
.doc("The location of server events go for the builtin JSON logger")
.version("1.4.0")
.stringConf
- .createWithDefault("/tmp/kyuubi/events")
+ .createWithDefault("file:///tmp/kyuubi/events")
- // TODO: #1181 Format does not conform to specifications
val ENGINE_EVENT_JSON_LOG_PATH: ConfigEntry[String] =
buildConf("engine.event.json.log.path")
.doc("The location of all the engine events go for the builtin JSON
logger.<ul>" +
- "<li>Local Path: start with 'file:'</li>" +
- "<li>HDFS Path: start with 'hdfs:'</li></ul>")
+ "<li>Local Path: start with 'file://'</li>" +
+ "<li>HDFS Path: start with 'hdfs://'</li></ul>")
.version("1.3.0")
.stringConf
- .createWithDefault("file:/tmp/kyuubi/events")
+ .createWithDefault("file:///tmp/kyuubi/events")
val SERVER_EVENT_LOGGERS: ConfigEntry[Seq[String]] =
buildConf("backend.server.event.loggers")
