This is an automated email from the ASF dual-hosted git repository.
ulyssesyou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git
The following commit(s) were added to refs/heads/master by this push:
new 55a7347 [KYUUBI #1425] Remove hardcode skipTests for
maven-surefire-plugin
55a7347 is described below
commit 55a7347b6f8eda31adc7e4841cd34d4a5e56dbb1
Author: fwang12 <[email protected]>
AuthorDate: Mon Nov 22 09:50:46 2021 +0800
[KYUUBI #1425] Remove hardcode skipTests for maven-surefire-plugin
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in
https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your
PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
So that we can transfer skipTests variable when build kyuubi binary.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including
negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run
test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests)
locally before make a pull request
Closes #1425 from turboFei/java_tst.
Closes #1425
094904d2 [fwang12] typo
af447e8c [fwang12] prevent hardcode
Authored-by: fwang12 <[email protected]>
Signed-off-by: ulysses-you <[email protected]>
---
.../src/main/java/org/apache/hive/beeline/KyuubiBeeLine.java | 6 +++---
kyuubi-hive-jdbc/pom.xml | 3 ---
pom.xml | 1 -
3 files changed, 3 insertions(+), 7 deletions(-)
diff --git
a/kyuubi-hive-beeline/src/main/java/org/apache/hive/beeline/KyuubiBeeLine.java
b/kyuubi-hive-beeline/src/main/java/org/apache/hive/beeline/KyuubiBeeLine.java
index 60c1e9d..06d49e8 100644
---
a/kyuubi-hive-beeline/src/main/java/org/apache/hive/beeline/KyuubiBeeLine.java
+++
b/kyuubi-hive-beeline/src/main/java/org/apache/hive/beeline/KyuubiBeeLine.java
@@ -35,9 +35,9 @@ public class KyuubiBeeLine extends BeeLine {
public KyuubiBeeLine(boolean isBeeLine) {
super(isBeeLine);
try {
- Field commandsFiled = BeeLine.class.getDeclaredField("commands");
- commandsFiled.setAccessible(true);
- commandsFiled.set(this, commands);
+ Field commandsField = BeeLine.class.getDeclaredField("commands");
+ commandsField.setAccessible(true);
+ commandsField.set(this, commands);
} catch (Throwable t) {
throw new ExceptionInInitializerError("Failed to inject kyuubi
commands");
}
diff --git a/kyuubi-hive-jdbc/pom.xml b/kyuubi-hive-jdbc/pom.xml
index 139fa91..3738e0b 100644
--- a/kyuubi-hive-jdbc/pom.xml
+++ b/kyuubi-hive-jdbc/pom.xml
@@ -267,9 +267,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
- <configuration>
- <skipTests>false</skipTests>
- </configuration>
</plugin>
<plugin>
diff --git a/pom.xml b/pom.xml
index dbd3cab..cc0c7e9 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1136,7 +1136,6 @@
<artifactId>maven-surefire-plugin</artifactId>
<version>${maven.plugin.surefire.version}</version>
<configuration>
- <skipTests>true</skipTests>
<includes>
<include>**/Test*.java</include>
<include>**/*Test.java</include>
