This is an automated email from the ASF dual-hosted git repository.

chengpan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git


The following commit(s) were added to refs/heads/master by this push:
     new 0489250  [KYUUBI #1424] Share jars between server and beeline to 
reduce binary size
0489250 is described below

commit 0489250e3b6638dd0ac18ad3dbd52f4599f07b13
Author: fwang12 <[email protected]>
AuthorDate: Tue Nov 23 10:03:35 2021 +0800

    [KYUUBI #1424] Share jars between server and beeline to reduce binary size
    
    <!--
    Thanks for sending a pull request!
    
    Here are some tips for you:
      1. If this is your first time, please read our contributor guidelines: 
https://kyuubi.readthedocs.io/en/latest/community/contributions.html
      2. If the PR is related to an issue in 
https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your 
PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
      3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., 
'[WIP][KYUUBI #XXXX] Your PR title ...'.
    -->
    
    ### _Why are the changes needed?_
    <!--
    Please clarify why the changes are needed. For instance,
      1. If you add a feature, you can talk about the use case of it.
      2. If you fix a bug, you can clarify why it is a bug.
    -->
    Share jars between server and beeline to reduce binary size.
    
    ### _How was this patch tested?_
    - [ ] Add some test cases that check the changes thoroughly including 
negative and positive cases if possible
    
    - [ ] Add screenshots for manual tests if appropriate
    
    - [x] [Run 
test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests)
 locally before make a pull request
    
    Closes #1424 from turboFei/share.
    
    Closes #1424
    
    8147a94d [fwang12] use relative path
    238df243 [fwang12] refactor
    e7069e0c [fwang12] share jars between server and cli
    
    Authored-by: fwang12 <[email protected]>
    Signed-off-by: Cheng Pan <[email protected]>
---
 build/dist | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/build/dist b/build/dist
index 4956e2a..af126c4 100755
--- a/build/dist
+++ b/build/dist
@@ -192,6 +192,16 @@ cp -r 
"$KYUUBI_HOME/kyuubi-assembly/target/scala-$SCALA_VERSION/jars/" "$DISTDIR
 # Copy kyuubi beeline jars
 cp "$KYUUBI_HOME"/kyuubi-hive-beeline/target/*.jar "$DISTDIR/beeline-jars/"
 
+# Share the jars between server and beeline to reduce binary size
+cd $DISTDIR/beeline-jars
+for jar in $(ls "$DISTDIR/jars/"); do
+  if [[ -f "$DISTDIR/beeline-jars/$jar" ]]; then
+    rm "$DISTDIR/beeline-jars/$jar"
+    ln -sn "../jars/$jar" "$DISTDIR/beeline-jars/$jar"
+  fi
+done
+cd -
+
 # Copy spark engines
 cp 
"$KYUUBI_HOME/externals/kyuubi-spark-sql-engine/target/kyuubi-spark-sql-engine_${SCALA_VERSION}-${VERSION}.jar"
 "$DISTDIR/externals/engines/spark"
 

Reply via email to