yaooqinn commented on a change in pull request #1448:
URL: https://github.com/apache/incubator-kyuubi/pull/1448#discussion_r758895623
##########
File path:
kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/client/ServiceDiscovery.scala
##########
@@ -48,92 +48,34 @@ import org.apache.kyuubi.util.{KyuubiHadoopUtils,
ThreadUtils}
*/
abstract class ServiceDiscovery(
name: String,
- fe: FrontendService) extends AbstractService(name) {
+ val fe: FrontendService) extends AbstractService(name) {
- import ServiceDiscovery._
- import ZooKeeperClientProvider._
-
- private var _zkClient: CuratorFramework = _
- private var _serviceNode: PersistentNode = _
-
- /**
- * a pre-defined namespace used to publish the instance of the associate
service
- */
+ private var _discoveryClient: ServiceDiscoveryClient = _
private var _namespace: String = _
Review comment:
we don't need this anymore?
##########
File path:
kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/client/ServiceDiscovery.scala
##########
@@ -48,92 +48,34 @@ import org.apache.kyuubi.util.{KyuubiHadoopUtils,
ThreadUtils}
*/
abstract class ServiceDiscovery(
name: String,
- fe: FrontendService) extends AbstractService(name) {
+ val fe: FrontendService) extends AbstractService(name) {
- import ServiceDiscovery._
- import ZooKeeperClientProvider._
-
- private var _zkClient: CuratorFramework = _
- private var _serviceNode: PersistentNode = _
-
- /**
- * a pre-defined namespace used to publish the instance of the associate
service
- */
+ private var _discoveryClient: ServiceDiscoveryClient = _
private var _namespace: String = _
- def zkClient: CuratorFramework = _zkClient
-
- def serviceNode: PersistentNode = _serviceNode
-
+ def discoveryClient: ServiceDiscoveryClient = _discoveryClient
def namespace: String = _namespace
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
