ulysses-you commented on a change in pull request #1869:
URL: https://github.com/apache/incubator-kyuubi/pull/1869#discussion_r801664269
##########
File path: externals/kyuubi-flink-sql-engine/pom.xml
##########
@@ -165,7 +165,7 @@
<include>com.google.guava:failureaccess</include>
<include>com.google.guava:guava</include>
<include>commons-codec:commons-codec</include>
- <include>io.netty:netty-all</include>
+ <include>io.netty:*</include>
Review comment:
The obvious place is `KyuubiConf`, it uses
`NettyUtils.MAX_NETTY_THREADS`.
The netty dependency is introduced for mysql frontend. So I think we can
remove the netty dependency at engine side ? @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
