yaooqinn commented on a change in pull request #1892:
URL: https://github.com/apache/incubator-kyuubi/pull/1892#discussion_r804428541
##########
File path:
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
##########
@@ -1172,6 +1172,13 @@ object KyuubiConf {
.checkValues(OperationLanguages.values.map(_.toString))
.createWithDefault(OperationLanguages.SQL.toString)
+ val SESSION_CONF_ADVISOR: OptionalConfigEntry[String] =
+ buildConf("session.conf.advisor")
+ .doc("Choose a custom config advisor for session, the default
implementation return empty.")
Review comment:
let's detail the doc of the config, e.g. what's happening while using
this plugin, not just duplicates the config name with some words reordered,
besides `the default implementation return empty` is redundant too as we will
have a `<td>` for default value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
